From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Emo-0007rV-N1 for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:20:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Emj-0001p9-Nz for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:20:26 -0500 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:33924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Emj-0001ot-HN for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:20:21 -0500 Received: by mail-qc0-f177.google.com with SMTP id m20so17754599qcx.36 for ; Mon, 06 Jan 2014 10:20:20 -0800 (PST) Sender: Richard Henderson Message-ID: <52CAF3E0.109@twiddle.net> Date: Mon, 06 Jan 2014 10:20:16 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389013881-15726-1-git-send-email-peter.maydell@linaro.org> <1389013881-15726-5-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1389013881-15726-5-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 04/24] softfloat: Make the int-to-float functions take exact-width types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Tom Musta , Peter Crosthwaite , patches@linaro.org, Michael Matz , Alexander Graf , Claudio Fontana , Dirk Mueller , Will Newton , Laurent Desnogues , =?ISO-8859-1?Q?Alex_Benn=E9e?= , kvmarm@lists.cs.columbia.edu, Christoffer Dall On 01/06/2014 05:11 AM, Peter Maydell wrote: > Currently the int-to-float functions take types which are specified > as "at least X bits wide", rather than "exactly X bits wide". This is > confusing and unhelpful since it means that the callers have to include > an explicit cast to [u]intXX_t to ensure the correct behaviour. Fix > them all to take the exactly-X-bits-wide types instead. > > Note that this doesn't change behaviour at all since at the moment > we happen to define the 'int32' and 'uint32' types as exactly 32 bits > wide, and the 'int64' and 'uint64' types as exactly 64 bits wide. > > Signed-off-by: Peter Maydell > --- > fpu/softfloat.c | 26 +++++++++++++------------- > include/fpu/softfloat.h | 26 +++++++++++++------------- > 2 files changed, 26 insertions(+), 26 deletions(-) Reviewed-by: Richard Henderson r~