From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W0FIM-0004tz-Eg
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:53:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W0FIG-00033F-K5
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:53:02 -0500
Received: from mail-qe0-x229.google.com ([2607:f8b0:400d:c02::229]:40501)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W0FIG-000331-E6
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 13:52:56 -0500
Received: by mail-qe0-f41.google.com with SMTP id gh4so19283522qeb.0
	for <qemu-devel@nongnu.org>; Mon, 06 Jan 2014 10:52:55 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52CAFB81.9030709@twiddle.net>
Date: Mon, 06 Jan 2014 10:52:49 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389013881-15726-1-git-send-email-peter.maydell@linaro.org>
	<1389013881-15726-24-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389013881-15726-24-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 23/24] target-arm: A64: Add 1-source
 32-to-32 and 64-to-64 FP instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/06/2014 05:11 AM, Peter Maydell wrote:
> +DEF_HELPER_FLAGS_2(rints_exact, TCG_CALL_NO_RWG_SE, f32, f32, ptr)
> +DEF_HELPER_FLAGS_2(rintd_exact, TCG_CALL_NO_RWG_SE, f64, f64, ptr)
> +DEF_HELPER_FLAGS_2(rints, TCG_CALL_NO_RWG_SE, f32, f32, ptr)
> +DEF_HELPER_FLAGS_2(rintd, TCG_CALL_NO_RWG_SE, f64, f64, ptr)

These have side effects in the fp_status.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~