From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Fnk-0002Nc-Cl for qemu-devel@nongnu.org; Mon, 06 Jan 2014 14:25:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Fnf-00047N-HI for qemu-devel@nongnu.org; Mon, 06 Jan 2014 14:25:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Fnf-000461-9c for qemu-devel@nongnu.org; Mon, 06 Jan 2014 14:25:23 -0500 Message-ID: <52CB0317.8010506@redhat.com> Date: Mon, 06 Jan 2014 20:25:11 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1388906864-1083-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1388906864-1083-6-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1388906864-1083-6-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qiao Nuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, akong@redhat.com, afaerber@suse.de On 01/05/14 08:27, Qiao Nuohan wrote: > kdump-compressed format supports three compression format, zlib/lzo/snappy. > Currently, only zlib is available. This patch is used to support lzo/snappy. > '--enable-lzo/--enable-snappy' is needed to be specified with configure to make > lzo/snappy available for qemu > > Signed-off-by: Qiao Nuohan > --- > configure | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 50 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index edfea95..b7a28b7 100755 > --- a/configure > +++ b/configure > @@ -245,6 +245,8 @@ libusb="" > usb_redir="" > glx="" > zlib="yes" > +lzo="no" > +snappy="no" > guest_agent="" > guest_agent_with_vss="no" > vss_win32_sdk="" > @@ -947,6 +949,10 @@ for opt do > ;; > --disable-zlib-test) zlib="no" > ;; > + --enable-lzo) lzo="yes" > + ;; > + --enable-snappy) snappy="yes" > + ;; > --enable-guest-agent) guest_agent="yes" > ;; > --disable-guest-agent) guest_agent="no" > @@ -1538,6 +1544,42 @@ fi > libs_softmmu="$libs_softmmu -lz" > > ########################################## > +# lzo check > + > +if test "$lzo" != "no" ; then > + cat > $TMPC << EOF > +#include > +int main(void) { lzo_version(); return 0; } > +EOF > + if compile_prog "" "-llzo2" ; then > + : > + else > + error_exit "lzo check failed" \ > + "Make sure to have the lzo libs and headers installed." > + fi > + > + libs_softmmu="$libs_softmmu -llzo2" > +fi > + > +########################################## > +# snappy check > + > +if test "$snappy" != "no" ; then > + cat > $TMPC << EOF > +#include > +int main(void) { snappy_max_compressed_length(4096); return 0; } > +EOF > + if compile_prog "" "-lsnappy" ; then > + : > + else > + error_exit "snappy check failed" \ > + "Make sure to have the snappy libs and headers installed." > + fi > + > + libs_softmmu="$libs_softmmu -lsnappy" > +fi > + > +########################################## > # libseccomp check > > if test "$seccomp" != "no" ; then > @@ -4135,6 +4177,14 @@ if test "$glx" = "yes" ; then > echo "GLX_LIBS=$glx_libs" >> $config_host_mak > fi > > +if test "$lzo" = "yes" ; then > + echo "CONFIG_LZO=y" >> $config_host_mak > +fi > + > +if test "$snappy" = "yes" ; then > + echo "CONFIG_SNAPPY=y" >> $config_host_mak > +fi > + > if test "$libiscsi" = "yes" ; then > echo "CONFIG_LIBISCSI=y" >> $config_host_mak > fi > You could have displayed the lzo / snappy settings along with the other settings in the "big echo block". But it's not too important; if you want you can add it later. Reviewed-by: Laszlo Ersek