From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0MnJ-0004p5-Sl for qemu-devel@nongnu.org; Mon, 06 Jan 2014 21:53:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0MnA-0004AE-T1 for qemu-devel@nongnu.org; Mon, 06 Jan 2014 21:53:29 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:54492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0MnA-00049E-Aq for qemu-devel@nongnu.org; Mon, 06 Jan 2014 21:53:20 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Jan 2014 08:23:17 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 40C471258056 for ; Tue, 7 Jan 2014 08:24:42 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s072r7ZS49938488 for ; Tue, 7 Jan 2014 08:23:08 +0530 Received: from d28av05.in.ibm.com (localhost [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s072rD8Z009697 for ; Tue, 7 Jan 2014 08:23:13 +0530 Message-ID: <52CB6C18.70908@linux.vnet.ibm.com> Date: Tue, 07 Jan 2014 10:53:12 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388704234-22498-4-git-send-email-xiawenc@linux.vnet.ibm.com> <20140106181004.192b4472@redhat.com> In-Reply-To: <20140106181004.192b4472@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com >> diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py >> new file mode 100644 >> index 0000000..7526366 >> --- /dev/null >> +++ b/scripts/qapi-event.py >> @@ -0,0 +1,432 @@ >> +# >> +# QAPI event generator >> +# >> +# Copyright IBM, Corp. 2014 >> +# >> +# Authors: >> +# Wenchao Xia >> +# >> +# This work is licensed under the terms of the GNU GPLv2+ or later. >> +# See the COPYING.LIB file in the top-level directory. >> + >> +from ordereddict import OrderedDict >> +from qapi import * >> +import sys >> +import os >> +import getopt >> +import errno >> + >> +def _generate_event_api_name(event_name, params): > > Why the underline? And, what you generate is a function declaration... > I want to tip it is not a public API. It is generating API name, missing ";" for declaration, implement may want it without ";". :) >> + api_name = "void qapi_event_send_%s(" % c_fun(event_name).lower(); >> + l = len(api_name) >> + >> + if params: >> + for argname, argentry, optional, structured in parse_args(params): >> + if structured: >> + sys.stderr.write("Nested structure define in event is not " >> + "supported now, event '%s', argname '%s'\n" % >> + (event_name, argname)) >> + sys.exit(1) >> + continue >> + >> + if optional: >> + api_name += "bool has_%s,\n" % c_var(argname) >> + api_name += "".ljust(l) >> + >> + if argentry == "str": >> + api_name += "const " >> + api_name += "%s %s,\n" % (c_type(argentry), c_var(argname)) >> + api_name += "".ljust(l) >> + >> + api_name += "Error **errp)" >> + return api_name; >> + >> + >> +# Following are the core functions that transate user input into a qdict going > > s/transate/translate > > Although the comment doesn't make much sense to me. > OK, let me improve. >> +# to be emitted in the wire. >> + >> +def generate_event_declaration(api_name): >> + return mcgen(''' >> + >> +%(api_name)s; >> +''', >> + api_name = api_name) >> + >> +def generate_event_implement(api_name, event_name, params): > > I wonder if it would be clearer to to generate the declaration here. > I think so, but a little slower at compile time. I use api_name to avoid call _generate_event_api_name() twice. I am not sure which way is better.