From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0jrh-00056z-Fs for qemu-devel@nongnu.org; Tue, 07 Jan 2014 22:31:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0jrb-00076b-Av for qemu-devel@nongnu.org; Tue, 07 Jan 2014 22:31:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0jrb-00076W-1Q for qemu-devel@nongnu.org; Tue, 07 Jan 2014 22:31:27 -0500 Message-ID: <52CCC679.2070806@redhat.com> Date: Wed, 08 Jan 2014 11:31:05 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1386920120-2651-1-git-send-email-famz@redhat.com> <1386920120-2651-3-git-send-email-famz@redhat.com> <20140103100914.GE1483@stefanha-thinkpad.redhat.com> <52CCB7EB.4040700@redhat.com> <20140108032648.GA30570@stefanha-thinkpad.redhat.com> In-Reply-To: <20140108032648.GA30570@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 02/12] qapi: Add BlockOperationType enum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, rjones@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, armbru@redhat.com, imain@redhat.com, pbonzini@redhat.com On 2014=E5=B9=B401=E6=9C=8808=E6=97=A5 11:26, Stefan Hajnoczi wrote: > On Wed, Jan 08, 2014 at 10:28:59AM +0800, Fam Zheng wrote: >> On 2014=E5=B9=B401=E6=9C=8803=E6=97=A5 18:09, Stefan Hajnoczi wrote: >>> On Fri, Dec 13, 2013 at 03:35:10PM +0800, Fam Zheng wrote: >>>> This adds the enum of all the operations that can be taken on a bloc= k >>>> device. >>>> >>>> Signed-off-by: Fam Zheng >>>> --- >>>> qapi-schema.json | 50 ++++++++++++++++++++++++++++++++++++++++++++= ++++++ >>>> 1 file changed, 50 insertions(+) >>>> >>>> diff --git a/qapi-schema.json b/qapi-schema.json >>>> index d6f8615..8e982a2 100644 >>>> --- a/qapi-schema.json >>>> +++ b/qapi-schema.json >>>> @@ -1440,6 +1440,56 @@ >>>> 'data': ['commit', 'stream', 'mirror', 'backup'] } >>>> >>>> ## >>>> +# @BlockOperationType >>>> +# >>>> +# Type of a block operation. (since 2.0) >>> >>> Why is this exposed in qapi-schema.json? The blockers concept is >>> internal to QEMU and not exposed via QMP. >>> >> >> I plan to add it into block information (query-block, for example). >> But in follow up patches. It could be useful for user to check which >> commands/operations are possible without trial-and-fail, when we put >> more and more complicated state and configuration into the BDS >> graph. > > Can you make it internal for now and expose via QMP if necessary later? > > I think we shouldn't commit to public APIs unless they are ready and > provide a useful service, since we cannot change them. > OK, works for me. Fam