From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0nZX-0002c5-IN for qemu-devel@nongnu.org; Wed, 08 Jan 2014 02:29:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0nZR-0004oK-JY for qemu-devel@nongnu.org; Wed, 08 Jan 2014 02:29:03 -0500 Received: from [222.73.24.84] (port=51592 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0nZR-0004mM-90 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 02:28:57 -0500 Message-ID: <52CCFDEE.6080808@cn.fujitsu.com> Date: Wed, 08 Jan 2014 15:27:42 +0800 From: Li Guang MIME-Version: 1.0 References: <1388654332-10303-1-git-send-email-b.galvani@gmail.com> <1388654332-10303-3-git-send-email-b.galvani@gmail.com> <52C9FD8E.5040200@cn.fujitsu.com> <20140106135643.GA4400@gmail.com> In-Reply-To: <20140106135643.GA4400@gmail.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Subject: Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Beniamino Galvani Cc: Peter Maydell , qemu-devel@nongnu.org Beniamino Galvani wrote: > On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote: > >> Hi, >> please use prefix AwA10 for names instead of Aw, >> also PATCH 1/2. >> > Hi, > > I agree with you that there is an inconsistency in the naming of EMAC > and other A10 devices (timer, interrupt controller). > > But the EMAC core is used not only on the A10; since it can be found > on other SoC of the Allwinner family, shouldn't the name be generic so > that it can be reused more easily in the future by other SoC > implementations? > > logic is: we emulated devices in A10, then when emulate other chips with same devices can freely use them. Thanks!