From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0oPH-0003IY-JY for qemu-devel@nongnu.org; Wed, 08 Jan 2014 03:22:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0oPB-00038T-Ju for qemu-devel@nongnu.org; Wed, 08 Jan 2014 03:22:31 -0500 Received: from smtp.dmail.dachary.org ([91.121.254.229]:45546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0oPB-00038N-Dm for qemu-devel@nongnu.org; Wed, 08 Jan 2014 03:22:25 -0500 Message-ID: <52CD0ABD.3090709@dachary.org> Date: Wed, 08 Jan 2014 09:22:21 +0100 From: Loic Dachary MIME-Version: 1.0 References: <1388363614-25411-1-git-send-email-loic@dachary.org> <20140106022338.GC9790@stefanha-thinkpad.redhat.com> <52CAD0D1.8080508@dachary.org> <20140108043349.GF30570@stefanha-thinkpad.redhat.com> In-Reply-To: <20140108043349.GF30570@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0TRm0gOWPvm5XIVLmKCs5wtsJbRsOrtdN" Subject: Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Josh Durgin , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0TRm0gOWPvm5XIVLmKCs5wtsJbRsOrtdN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 08/01/2014 05:33, Stefan Hajnoczi wrote: > On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote: >> >> >> On 06/01/2014 03:23, Stefan Hajnoczi wrote: >>> On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: >>>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/commo= n.rc >>>> index 28ba0d9..af66bbd 100644 >>>> --- a/tests/qemu-iotests/common.rc >>>> +++ b/tests/qemu-iotests/common.rc >>>> @@ -189,7 +189,11 @@ _cleanup_test_img() >>>> ;; >>>> =20 >>>> rbd) >>>> - rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null >>> >>> stderr will be displayed. Why isn't this enough? >>> >> >> Because the progress of the removal operation will be displayed on std= err. rbd outputs on stderr even when there is no error. >=20 > Is that a bug in the rbd tool which should be fixed? Either by printin= g > progress to stdout or by adding a --quiet option? In my opinion, yes. But Josh may disagree ;-) --=20 Lo=EFc Dachary, Artisan Logiciel Libre --0TRm0gOWPvm5XIVLmKCs5wtsJbRsOrtdN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlLNCr0ACgkQ8dLMyEl6F229IQCfSAP7ZkpuxBgCIm0PqDUmm1J8 zAUAnRwaeB7IGgSYaPUpIuCrwtYgDJWf =Aafr -----END PGP SIGNATURE----- --0TRm0gOWPvm5XIVLmKCs5wtsJbRsOrtdN--