From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0que-00057q-Up for qemu-devel@nongnu.org; Wed, 08 Jan 2014 06:03:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0quX-0006Cm-Bl for qemu-devel@nongnu.org; Wed, 08 Jan 2014 06:03:04 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:34089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0quX-0006Ci-5E for qemu-devel@nongnu.org; Wed, 08 Jan 2014 06:02:57 -0500 Received: by mail-ee0-f54.google.com with SMTP id e51so492058eek.41 for ; Wed, 08 Jan 2014 03:02:21 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52CD3039.8030409@redhat.com> Date: Wed, 08 Jan 2014 12:02:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1387503694-11203-1-git-send-email-agraf@suse.de> <87lhzelc2k.fsf@blackfin.pond.sub.org> <52B6EC8F.8080107@redhat.com> <87k3ebddw0.fsf@blackfin.pond.sub.org> <52CC3275.9010502@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Alexander Graf , =?ISO-8859-1?Q?Andreas_F=E4rber?= , QEMU Developers , Anthony Liguori , Markus Armbruster Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: >> > The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, >> > 2013-06-18). Should probably be reverted. >> > > Prefer not, under no reasonable definition is NAND a sysbus device. > Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to > qtree that TYPE_DEVICE is not? The device's dev->parent_bus is main_system_bus. Paolo