From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0tMw-0002T6-72 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 08:40:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0tMp-0000A4-VP for qemu-devel@nongnu.org; Wed, 08 Jan 2014 08:40:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37041 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0tMp-00009i-OS for qemu-devel@nongnu.org; Wed, 08 Jan 2014 08:40:19 -0500 Message-ID: <52CD553D.3050207@suse.de> Date: Wed, 08 Jan 2014 14:40:13 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387503694-11203-1-git-send-email-agraf@suse.de> <87lhzelc2k.fsf@blackfin.pond.sub.org> <52B6EC8F.8080107@redhat.com> <87k3ebddw0.fsf@blackfin.pond.sub.org> <52CC3275.9010502@redhat.com> <87sisyc2m3.fsf@blackfin.pond.sub.org> In-Reply-To: <87sisyc2m3.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Peter Crosthwaite Cc: Paolo Bonzini , QEMU Developers , Anthony Liguori , Alexander Graf Am 08.01.2014 09:13, schrieb Markus Armbruster: > Peter Crosthwaite writes: >=20 >> On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wr= ote: >>> Il 07/01/2014 16:12, Markus Armbruster ha scritto: >>>> aarch64 akita info qtree crashes >>>> aarch64 borzoi info qtree crashes >>>> aarch64 spitz info qtree crashes >>>> aarch64 terrier info qtree crashes >>>> aarch64 tosa info qtree crashes >>>> arm akita info qtree crashes >>>> arm borzoi info qtree crashes >>>> arm spitz info qtree crashes >>>> arm terrier info qtree crashes >>>> arm tosa info qtree crashes >>>> cris axis-dev88 info qtree crashes >>> >>> The crash is because of commit 7426aa7 (nand: Don't inherit from Sysb= us, >>> 2013-06-18). Should probably be reverted. >>> >> >> Prefer not, under no reasonable definition is NAND a sysbus device. >> Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to >> qtree that TYPE_DEVICE is not? >=20 > Maybe, but our definition of sysbus has never been reasonable :) >=20 > Qdev, as designed by Paul Brook, assumed the parent of a qdev is always > a qbus and vice versa. With the exception of the root, which has no > parent, and is a sysbus, commonly the only one. >=20 > A PCI qdev plugs into a PCI qbus, an USB qdev plugs into an USB qbus, > and so forth. Any qdev that doesn't really plug into a bus was made a > "sysbus device" by fiat. "Sysbus" is a catchall, no more. In > particular, it's not a bus in the hardware sense. >=20 > This "everything plugs into exactly one bus" assumption is of course a > gross oversimplification, and we've been working on overcoming it for > quite some time. It has become possible to define qdevs that aren't > connected to a qbus. A TYPE_DEVICE isn't. >=20 > That's progress. But progress isn't justification for not fixing crash > bugs in monitor commands. >=20 > Either you fix "info qtree" to cope with your change to the device > graph, or the change needs to be reverted until somebody fixes it or it > goes away. Sharing a backtrace would be a start, rather than just throwing around the word "crash" to justify reverting patches. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg