From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus
Date: Wed, 08 Jan 2014 14:53:14 +0100 [thread overview]
Message-ID: <52CD584A.2040909@suse.de> (raw)
In-Reply-To: <52CD3039.8030409@redhat.com>
Am 08.01.2014 12:02, schrieb Paolo Bonzini:
> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto:
>>>> The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus,
>>>> 2013-06-18). Should probably be reverted.
>>>>
>> Prefer not, under no reasonable definition is NAND a sysbus device.
>> Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to
>> qtree that TYPE_DEVICE is not?
>
> The device's dev->parent_bus is main_system_bus.
Meaning in turn that qdev_create() was used rather then object_new().
Simple fix. :)
Possibly already in my pending qom-next pull?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-01-08 13:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 1:41 [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus Alexander Graf
2013-12-21 10:42 ` Markus Armbruster
2013-12-22 13:43 ` Paolo Bonzini
2014-01-07 15:12 ` Markus Armbruster
2014-01-07 16:59 ` Paolo Bonzini
2014-01-07 17:34 ` Markus Armbruster
2014-01-08 14:04 ` Paolo Bonzini
2014-01-08 14:35 ` Markus Armbruster
2014-01-08 15:18 ` Paolo Bonzini
2014-01-08 16:52 ` Markus Armbruster
2014-01-08 3:07 ` Peter Crosthwaite
2014-01-08 4:24 ` Andreas Färber
2014-01-08 8:00 ` Markus Armbruster
2014-01-08 10:11 ` Peter Maydell
2014-01-08 8:13 ` Markus Armbruster
2014-01-08 8:26 ` Peter Crosthwaite
2014-01-08 13:40 ` Andreas Färber
2014-01-08 13:47 ` Paolo Bonzini
2014-01-10 7:50 ` Peter Crosthwaite
2014-01-10 8:48 ` Markus Armbruster
2014-02-04 9:28 ` Markus Armbruster
2014-02-05 5:19 ` Peter Crosthwaite
2014-02-05 8:45 ` Markus Armbruster
2014-01-08 11:02 ` Paolo Bonzini
2014-01-08 13:53 ` Andreas Färber [this message]
2014-01-08 14:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD584A.2040909@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).