From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W0tZX-0006mr-2q
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 08:53:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W0tZP-0003rM-PD
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 08:53:27 -0500
Received: from cantor2.suse.de ([195.135.220.15]:37331 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1W0tZP-0003rC-F7
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 08:53:19 -0500
Message-ID: <52CD584A.2040909@suse.de>
Date: Wed, 08 Jan 2014 14:53:14 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1387503694-11203-1-git-send-email-agraf@suse.de>
	<87lhzelc2k.fsf@blackfin.pond.sub.org>
	<52B6EC8F.8080107@redhat.com>
	<87k3ebddw0.fsf@blackfin.pond.sub.org>
	<52CC3275.9010502@redhat.com>
	<CAEgOgz5b53V+k+1w0-pY2fzKi=dMJbVMpTjDs1cziihhL1XA3A@mail.gmail.com>
	<52CD3039.8030409@redhat.com>
In-Reply-To: <52CD3039.8030409@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter
	per bus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@amazon.com>, Markus Armbruster <armbru@redhat.com>

Am 08.01.2014 12:02, schrieb Paolo Bonzini:
> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto:
>>>> The crash is because of commit 7426aa7 (nand: Don't inherit from Sys=
bus,
>>>> 2013-06-18).   Should probably be reverted.
>>>>
>> Prefer not, under no reasonable definition is NAND a sysbus device.
>> Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to
>> qtree that TYPE_DEVICE is not?
>=20
> The device's dev->parent_bus is main_system_bus.

Meaning in turn that qdev_create() was used rather then object_new().
Simple fix. :)

Possibly already in my pending qom-next pull?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg