From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0tkT-0001DU-Rc for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:04:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0tkK-0007Kz-HQ for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:04:45 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:51619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0tkK-0007Ko-B2 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:04:36 -0500 Received: by mail-ea0-f180.google.com with SMTP id f15so846021eak.39 for ; Wed, 08 Jan 2014 06:04:35 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52CD5AEA.4050905@redhat.com> Date: Wed, 08 Jan 2014 15:04:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1387503694-11203-1-git-send-email-agraf@suse.de> <87lhzelc2k.fsf@blackfin.pond.sub.org> <52B6EC8F.8080107@redhat.com> <87k3ebddw0.fsf@blackfin.pond.sub.org> <52CC3275.9010502@redhat.com> <87iotvk863.fsf@blackfin.pond.sub.org> In-Reply-To: <87iotvk863.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Crosthwaite , Alexander Graf , Anthony Liguori , QEMU Developers Leaving only those that will be affected by the patch: Il 07/01/2014 18:34, Markus Armbruster ha scritto: > target machine bus id times > aarch64 n800 i2c-bus.0 2 > aarch64 n810 i2c-bus.0 2 > arm n800 i2c-bus.0 2 > arm n810 i2c-bus.0 2 Devices are created explicitly on one of the two buses, using s->mpu->i2c[0], so no change to the guest. > aarch64 vexpress-a15 virtio-mmio-bus.0 4 > aarch64 vexpress-a9 virtio-mmio-bus.0 4 > aarch64 virt virtio-mmio-bus.0 32 > arm vexpress-a15 virtio-mmio-bus.0 4 > arm vexpress-a9 virtio-mmio-bus.0 4 > arm virt virtio-mmio-bus.0 32 With Alex's patch we get the ability to plug the device in a particular slot. If anyone was using virtio-mmio-bus.0 explicitly, they get the first slot instead of the 4th or 32nd. Bugfix. > aarch64 xilinx-zynq-a9 usb-bus.0 2 > arm xilinx-zynq-a9 usb-bus.0 2 > mips64el fulong2e usb-bus.0 2 With Alex's patch we get the ability to plug the device in a particular controller. If anyone was using usb-bus.0 explicitly, they get the "other" controller. Guest visible change and not really a bugfix but it doesn't break working configurations (the position of USB devices should not be part of a device tree or firmware blob). It may break migration. > i386 isapc ide.0 2 > x86_64 isapc ide.0 2 (Ugly) fix in Alex's patch. The macio approach (using QOM children) is better. No need for a perfect fix now. > mips mips ide.0 2 > mips64 mips ide.0 2 > mips64el mips ide.0 2 > mipsel mips ide.0 2 Not affected, the bus is not stored anywhere. > ppc g3beige ide.0 2 > ppc mac99 ide.0 2 > ppc prep ide.0 2 > ppc64 g3beige ide.0 2 > ppc64 mac99 ide.0 2 > ppc64 prep ide.0 2 Trusting Alex's tests here. Paolo