From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W0tni-0002jN-SG
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:08:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W0tnY-000097-Vz
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:08:06 -0500
Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:50318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W0tnY-000093-PM
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:07:56 -0500
Received: by mail-ea0-f170.google.com with SMTP id k10so840718eaj.15
	for <qemu-devel@nongnu.org>; Wed, 08 Jan 2014 06:07:56 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52CD5BB7.4060707@redhat.com>
Date: Wed, 08 Jan 2014 15:07:51 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1387503694-11203-1-git-send-email-agraf@suse.de>
	<87lhzelc2k.fsf@blackfin.pond.sub.org>
	<52B6EC8F.8080107@redhat.com>
	<87k3ebddw0.fsf@blackfin.pond.sub.org>
	<52CC3275.9010502@redhat.com>
	<CAEgOgz5b53V+k+1w0-pY2fzKi=dMJbVMpTjDs1cziihhL1XA3A@mail.gmail.com>
	<52CD3039.8030409@redhat.com> <52CD584A.2040909@suse.de>
In-Reply-To: <52CD584A.2040909@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter
	per bus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Markus Armbruster <armbru@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@amazon.com>, QEMU Developers <qemu-devel@nongnu.org>

Il 08/01/2014 14:53, Andreas Färber ha scritto:
> Am 08.01.2014 12:02, schrieb Paolo Bonzini:
>> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto:
>>>>> The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus,
>>>>> 2013-06-18).   Should probably be reverted.
>>>>>
>>> Prefer not, under no reasonable definition is NAND a sysbus device.
>>> Whats the real problem here? What is TYPE_SYS_BUS_DEVICE doing WRT to
>>> qtree that TYPE_DEVICE is not?
>>
>> The device's dev->parent_bus is main_system_bus.
> 
> Meaning in turn that qdev_create() was used rather then object_new().
> Simple fix. :)

Happy as usual to be shown wrong! :)

> Possibly already in my pending qom-next pull?

No, unfortunately not.

Paolo