From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0uSb-0004KF-5H for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:50:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0uSV-0003nS-9g for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:50:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38398 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0uSV-0003n7-3b for qemu-devel@nongnu.org; Wed, 08 Jan 2014 09:50:15 -0500 Message-ID: <52CD65A3.1090306@suse.de> Date: Wed, 08 Jan 2014 15:50:11 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1389191134-16597-1-git-send-email-alex.bennee@linaro.org> <1389191134-16597-2-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1389191134-16597-2-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] scripts/qemu-binfmt-conf.sh: re-factor and clean-up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: alex.bennee@linaro.org, qemu-devel@nongnu.org Cc: patches@linaro.org Hi, Am 08.01.2014 15:25, schrieb alex.bennee@linaro.org: > From: Alex Benn=C3=A9e >=20 > I was looking to set-up for development but found the script made some > hard-coded assumptions. It doesn't seem the script is used by the > distros but if it had a little more love maybe it would be ;-) >=20 > * Add usage() instructions > * Move all registering to a single function > * Check for existence of executable qemu before registering > * Add -d (devel) mode for subscribing in-src tree binaries > * error handling when setting binfmt fails > * add support for aarch64 > --- > scripts/qemu-binfmt-conf.sh | 124 ++++++++++++++++++++++++++++++++++++= +------- > 1 file changed, 105 insertions(+), 19 deletions(-) > mode change 100644 =3D> 100755 scripts/qemu-binfmt-conf.sh Apart from both patches missing a Sob, did you take a look at the refactoring we discussed with Laurent Vivier (?) a while back? Essentially, there's multiple ways to register this, and based on our feedback he refactored it so that the magic strings can be retrieved individually. Don't remember where that got stuck... Regards Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg