From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W0vje-0007Ta-Sx
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:12:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W0vjY-000374-Tn
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:12:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13777)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W0vjY-000370-L7
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:11:56 -0500
Message-ID: <52CD78C4.8070403@redhat.com>
Date: Wed, 08 Jan 2014 17:11:48 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1388934290-27700-1-git-send-email-mmishael@redhat.com>
	<52CC1310.7070406@redhat.com>
	<DECD048F-03FE-42EB-9358-75B1D1849669@redhat.com>
In-Reply-To: <DECD048F-03FE-42EB-9358-75B1D1849669@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support
	in qemupciserial.inf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yan Vugenfirer <yvugenfi@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel list <qemu-devel@nongnu.org>, Ronen Hod <rhod@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Dmitry Fleytman <dfleytma@redhat.com>, Miki Mishael <mmishael@redhat.com>

Il 08/01/2014 16:07, Yan Vugenfirer ha scritto:
>>>
>>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1,
>>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2,
>>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4&REV_01
>>> +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4,
>>> PCI\VEN_1B36&DEV_0004&SUBSYS_11001AF4&REV_01
>>
>> I think checking the subsystem is not necessary (and I think downstreams
>> could legitimately change it).  Can you check CC and REV but not SUBSYS?
> 
> PNP ID can be reduced to vendor and device ID only, for example:
> PCI\VEN_1B36&DEV_0002 . But in this case we cannot check revision.

Gerd, Michael, what do you think is better?  Not check revision, or
enforcing subsystem?

Paolo