From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0vvy-0002Oj-6a for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:24:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0vvs-0006ZF-2P for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:24:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0vvr-0006ZA-PE for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:24:40 -0500 Message-ID: <52CD7BBF.3030202@redhat.com> Date: Wed, 08 Jan 2014 17:24:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1389197382-25085-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1389197382-25085-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/5] -object/object-add support custom location and 2nd stage initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: stefanha@redhat.com, sw@weilnetz.de, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, aliguori@amazon.com, afaerber@suse.de, rth@twiddle.net Il 08/01/2014 17:09, Igor Mammedov ha scritto: > Adds optional interfaces that objects could implement if > they need to: > 1. perform an additional initialization after object properties are set > 2. be placed not in '/objects' container > > Series depends on 2 PULL requests in flight from Andreas & Luiz > with fixes for QOM interfaces and object-add monitor/QMP command. > Git tree for testing: > https://github.com/imammedo/qemu/commits/extend-object-add > > Igor Mammedov (5): > object_add: consolidate error handling > add optional 2nd stage initialization to > -object/object-add/object_add commands > virtio_rng: use object_realize interface instead of calling backend > API > vl.c: -object: handle duplicate 'id' properly > -object/object-add: use custom default object location if provided > > backends/rng.c | 17 ++++++- > hw/virtio/virtio-rng.c | 15 ++++--- > include/qom/object_interfaces.h | 96 +++++++++++++++++++++++++++++++++++++++ > include/sysemu/rng.h | 11 ----- > qmp.c | 30 +++++++++--- > qom/Makefile.objs | 1 + > qom/object_interfaces.c | 57 +++++++++++++++++++++++ > vl.c | 21 ++++++++- > 8 files changed, 220 insertions(+), 28 deletions(-) > create mode 100644 include/qom/object_interfaces.h > create mode 100644 qom/object_interfaces.c > Thanks Igor! I like very much patches 1-4 (though I'm thinking that we need some style conventions for interfaces). I think patch 5 adds more complexity than we need, but I'm open to discussion. Paolo