From: Paolo Bonzini <pbonzini@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: stefanha@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, aliguori@amazon.com, imammedo@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided.
Date: Wed, 08 Jan 2014 18:34:01 +0100 [thread overview]
Message-ID: <52CD8C09.2070306@redhat.com> (raw)
In-Reply-To: <20140108171749.GB3717@Inspiron-3521>
Il 08/01/2014 18:17, Hani Benhabiles ha scritto:
> For this reason, the loop in assign_device_name() specifically check that the ID
> doesn't exist already and uses the next value if it does.
>
> How would something like:
> (qemu) device_add virtio-net-pci
> ==> ID: virtio-net-pci.0
>
> Be more problematic than:
> (qemu) device_add virtio-net-pci,id=virtio-net-pci.0
(qemu) device_add virtio-net-pci
(qemu) device_add virtio-net-pci,id=virtio-net-pci.0
works without your patches, fails with them (IIUC).
Paolo
next prev parent reply other threads:[~2014-01-08 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 19:07 [Qemu-devel] [PATCH] qdev: Assign a default device ID when none is provided Hani Benhabiles
2014-01-08 7:36 ` Markus Armbruster
2014-01-08 17:17 ` Hani Benhabiles
2014-01-08 17:34 ` Paolo Bonzini [this message]
2014-01-09 18:18 ` Hani Benhabiles
2014-01-09 18:33 ` Paolo Bonzini
2014-01-10 9:09 ` Markus Armbruster
2014-01-10 9:42 ` Andreas Färber
2014-01-10 11:54 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD8C09.2070306@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=kroosec@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).