From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0xuR-0004YW-CR for qemu-devel@nongnu.org; Wed, 08 Jan 2014 13:31:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0xuK-0002cF-6C for qemu-devel@nongnu.org; Wed, 08 Jan 2014 13:31:19 -0500 Sender: Richard Henderson Message-ID: <52CD996B.5060702@twiddle.net> Date: Wed, 08 Jan 2014 10:31:07 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389110770-5199-1-git-send-email-tommusta@gmail.com> <1389110770-5199-13-git-send-email-tommusta@gmail.com> In-Reply-To: <1389110770-5199-13-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V4 PATCH 12/22] target-ppc: Add ISA 2.06 fcfid[u][s] Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 01/07/2014 08:06 AM, Tom Musta wrote: > This patch adds the fcfids, fcfidu and fcfidus instructions which > were introduced in Power ISA 2.06B. A common macro is provided to > eliminate repetitious code, and the existing fcfid instruction is > refactored to use this macro. > > Signed-off-by: Tom Musta > --- > V4: Using the newly added PPC2_FP_CVT_ISA206 flag. Performed > direct conversion to single precision per Richard Henderson's > review. > > target-ppc/fpu_helper.c | 24 +++++++++++++++++------- > target-ppc/helper.h | 3 +++ > target-ppc/translate.c | 9 +++++++++ > 3 files changed, 29 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~