qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Josh Durgin <josh.durgin@inktank.com>
To: Loic Dachary <loic@dachary.org>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] discard rbd error output when not relevant in qemu-iotests
Date: Wed, 08 Jan 2014 13:25:09 -0800	[thread overview]
Message-ID: <52CDC235.1020101@inktank.com> (raw)
In-Reply-To: <1389211538-23364-1-git-send-email-loic@dachary.org>

On 01/08/2014 12:05 PM, Loic Dachary wrote:
> Suppress rbd progress messages with --no-progress so they are not
> confused with an error output when comparing test results ( progress is
> displayed on stderr ).
>
> Signed-off-by: Loic Dachary <loic@dachary.org>
> ---
>   tests/qemu-iotests/common.rc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 28ba0d9..7442bad 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -189,7 +189,7 @@ _cleanup_test_img()
>               ;;
>
>           rbd)
> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
> +            rbd --no-progress rm "$TEST_DIR/t.$IMGFMT" > /dev/null
>               ;;
>
>           sheepdog)
>

This flag was added in ceph 0.61. I doubt anyone is interested in
running these tests against earlier versions of ceph (the current stable
releases are 0.67 and 0.72).

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>

  reply	other threads:[~2014-01-08 21:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  0:33 [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests Loic Dachary
2013-12-30  0:39 ` Benoît Canet
2013-12-30  0:50   ` Loic Dachary
2014-01-06  2:23 ` Stefan Hajnoczi
2014-01-06 15:50   ` Loic Dachary
2014-01-08  4:33     ` Stefan Hajnoczi
2014-01-08  8:22       ` Loic Dachary
2014-01-08 20:05 ` [Qemu-devel] [PATCH v2] " Loic Dachary
2014-01-08 21:25   ` Josh Durgin [this message]
2014-01-09  1:45   ` Stefan Hajnoczi
2014-02-16 16:03     ` Benoît Canet
2014-02-27 15:22   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CDC235.1020101@inktank.com \
    --to=josh.durgin@inktank.com \
    --cc=loic@dachary.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).