From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <josh.durgin@inktank.com>) id 1W10di-0003f3-TH
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 16:26:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <josh.durgin@inktank.com>) id 1W10de-0004Kc-EM
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 16:26:14 -0500
Received: from mail-yh0-f52.google.com ([209.85.213.52]:41549)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <josh.durgin@inktank.com>) id 1W10de-0004KE-9p
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 16:26:10 -0500
Received: by mail-yh0-f52.google.com with SMTP id i7so594907yha.25
	for <qemu-devel@nongnu.org>; Wed, 08 Jan 2014 13:26:08 -0800 (PST)
Message-ID: <52CDC235.1020101@inktank.com>
Date: Wed, 08 Jan 2014 13:25:09 -0800
From: Josh Durgin <josh.durgin@inktank.com>
MIME-Version: 1.0
References: <1388363614-25411-1-git-send-email-loic@dachary.org>
	<1389211538-23364-1-git-send-email-loic@dachary.org>
In-Reply-To: <1389211538-23364-1-git-send-email-loic@dachary.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] discard rbd error output when not
	relevant in qemu-iotests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Loic Dachary <loic@dachary.org>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/08/2014 12:05 PM, Loic Dachary wrote:
> Suppress rbd progress messages with --no-progress so they are not
> confused with an error output when comparing test results ( progress is
> displayed on stderr ).
>
> Signed-off-by: Loic Dachary <loic@dachary.org>
> ---
>   tests/qemu-iotests/common.rc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 28ba0d9..7442bad 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -189,7 +189,7 @@ _cleanup_test_img()
>               ;;
>
>           rbd)
> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
> +            rbd --no-progress rm "$TEST_DIR/t.$IMGFMT" > /dev/null
>               ;;
>
>           sheepdog)
>

This flag was added in ceph 0.61. I doubt anyone is interested in
running these tests against earlier versions of ceph (the current stable
releases are 0.67 and 0.72).

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>