From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1B0S-0002Tc-9Q for qemu-devel@nongnu.org; Thu, 09 Jan 2014 03:30:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1B0K-0003oS-IF for qemu-devel@nongnu.org; Thu, 09 Jan 2014 03:30:24 -0500 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:36838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1B0I-0003nw-1K for qemu-devel@nongnu.org; Thu, 09 Jan 2014 03:30:16 -0500 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 9 Jan 2014 13:59:49 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 03A61394006A for ; Thu, 9 Jan 2014 13:59:46 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s098Ta9D7471342 for ; Thu, 9 Jan 2014 13:59:37 +0530 Received: from d28av05.in.ibm.com (localhost [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s098TbCJ014392 for ; Thu, 9 Jan 2014 13:59:38 +0530 Message-ID: <52CE5DF0.2040806@linux.vnet.ibm.com> Date: Thu, 09 Jan 2014 16:29:36 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1389172118-25402-1-git-send-email-pl@kamp.de> <1389172118-25402-7-git-send-email-pl@kamp.de> In-Reply-To: <1389172118-25402-7-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: sw@weilnetz.de, aliguori@amazon.com ÓÚ 2014/1/8 17:08, Peter Lieven дµÀ: > Signed-off-by: Peter Lieven > --- > ui/vnc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/ui/vnc.c b/ui/vnc.c > index da552fe..a742d32 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3170,7 +3170,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) > acl = 1; > #endif > } else if (strncmp(options, "lossy", 5) == 0) { > +#ifdef CONFIG_VNC_JPEG > vs->lossy = true; > +#endif > } else if (strncmp(options, "non-adaptive", 12) == 0) { > vs->non_adaptive = true; > } else if (strncmp(options, "share=", 6) == 0) { > @@ -3187,6 +3189,13 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) > } > } > > + /* adaptive updates are only used with tight encoding and > + * if lossy updates are enabled so we can disable all the > + * calculations otherwise */ > + if (!vs->lossy) { > + vs->non_adaptive = true; > + } > + The code seems: if vs->loosy == false, then vs->non_adaptive = true, translate as: if loosy update is not used, then don't do adaptive update., which doesn't conform with the comments. I am not sure if this is on expectation. > #ifdef CONFIG_VNC_TLS > if (acl && x509 && vs->tls.x509verify) { > if (!(vs->tls.acl = qemu_acl_init("vnc.x509dname"))) { >