From: "Andreas Färber" <afaerber@suse.de>
To: Will Newton <will.newton@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary
Date: Thu, 09 Jan 2014 13:03:06 +0100 [thread overview]
Message-ID: <52CE8FFA.5060800@suse.de> (raw)
In-Reply-To: <1389258650-22834-1-git-send-email-will.newton@linaro.org>
"... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls?
Am 09.01.2014 10:10, schrieb Will Newton:
> The regs parameter is not used anywhere, so remove it.
>
> Signed-off-by: Will Newton <will.newton@linaro.org>
> ---
> linux-user/elfload.c | 3 +--
> linux-user/flatload.c | 3 +--
> linux-user/linuxload.c | 4 ++--
> linux-user/qemu.h | 6 ++----
> 4 files changed, 6 insertions(+), 10 deletions(-)
Please CC your colleague as the maintainer, scripts/get_maintainer.pl
--nogit-fallback can help automate that.
Also you probably wanted patches@linaro.org, too. ;)
That said, patch contents look fine, without knowing the history,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-01-09 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 9:10 [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary Will Newton
2014-01-09 9:27 ` Erik de Castro Lopo
2014-01-09 9:31 ` Erik de Castro Lopo
2014-01-09 12:03 ` Andreas Färber [this message]
2014-01-10 6:30 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CE8FFA.5060800@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).