[Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

[Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

[Will Newton]

The regs parameter is not used anywhere, so remove it.

Signed-off-by: Will Newton <will.newton@linaro.org>
---
 linux-user/elfload.c   | 3 +--
 linux-user/flatload.c  | 3 +--
 linux-user/linuxload.c | 4 ++--
 linux-user/qemu.h      | 6 ++----
 4 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 8dd424d..5902f16 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1998,8 +1998,7 @@ give_up:
     free(syms);
 }
 
-int load_elf_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
-                    struct image_info * info)
+int load_elf_binary(struct linux_binprm *bprm, struct image_info *info)
 {
     struct image_info interp_info;
     struct elfhdr elf_ex;
diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index ceb89bb..566a7a8 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -704,8 +704,7 @@ static int load_flat_shared_library(int id, struct lib_info *libs)
 
 #endif /* CONFIG_BINFMT_SHARED_FLAT */
 
-int load_flt_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
-                    struct image_info * info)
+int load_flt_binary(struct linux_binprm *bprm, struct image_info *info)
 {
     struct lib_info libinfo[MAX_SHARED_LIBS];
     abi_ulong p = bprm->p;
diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c
index a1fe5ed..f2997c2 100644
--- a/linux-user/linuxload.c
+++ b/linux-user/linuxload.c
@@ -154,13 +154,13 @@ int loader_exec(int fdexec, const char *filename, char **argv, char **envp,
                 && bprm->buf[1] == 'E'
                 && bprm->buf[2] == 'L'
                 && bprm->buf[3] == 'F') {
-            retval = load_elf_binary(bprm, regs, infop);
+            retval = load_elf_binary(bprm, infop);
 #if defined(TARGET_HAS_BFLT)
         } else if (bprm->buf[0] == 'b'
                 && bprm->buf[1] == 'F'
                 && bprm->buf[2] == 'L'
                 && bprm->buf[3] == 'T') {
-            retval = load_flt_binary(bprm,regs,infop);
+            retval = load_flt_binary(bprm, infop);
 #endif
         } else {
             return -ENOEXEC;
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index e2717e0..c2f74f3 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -178,10 +178,8 @@ int loader_exec(int fdexec, const char *filename, char **argv, char **envp,
              struct target_pt_regs * regs, struct image_info *infop,
              struct linux_binprm *);
 
-int load_elf_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
-                    struct image_info * info);
-int load_flt_binary(struct linux_binprm * bprm, struct target_pt_regs * regs,
-                    struct image_info * info);
+int load_elf_binary(struct linux_binprm *bprm, struct image_info *info);
+int load_flt_binary(struct linux_binprm *bprm, struct image_info *info);
 
 abi_long memcpy_to_target(abi_ulong dest, const void *src,
                           unsigned long len);
-- 
1.8.1.4

Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

[Erik de Castro Lopo]

Will Newton wrote:

> The regs parameter is not used anywhere, so remove it.
> 
> Signed-off-by: Will Newton <will.newton@linaro.org>

Reviewed-by: Erik de Castro Lopo <erikd@mega-nerd.com>

-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

[Erik de Castro Lopo]

Will Newton wrote:

> The regs parameter is not used anywhere, so remove it.
> 
> Signed-off-by: Will Newton <will.newton@linaro.org>

Reviewed-by: Erik de Castro Lopo <erikd@mega-nerd.com>

-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

[Andreas Färber]

"... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls?

Am 09.01.2014 10:10, schrieb Will Newton:
> The regs parameter is not used anywhere, so remove it.
> 
> Signed-off-by: Will Newton <will.newton@linaro.org>
> ---
>  linux-user/elfload.c   | 3 +--
>  linux-user/flatload.c  | 3 +--
>  linux-user/linuxload.c | 4 ++--
>  linux-user/qemu.h      | 6 ++----
>  4 files changed, 6 insertions(+), 10 deletions(-)

Please CC your colleague as the maintainer, scripts/get_maintainer.pl
--nogit-fallback can help automate that.
Also you probably wanted patches@linaro.org, too. ;)

That said, patch contents look fine, without knowing the history,

Reviewed-by: Andreas Färber <afaerber@suse.de>

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary

[Riku Voipio]

Hi,

On Thu, Jan 09, 2014 at 01:03:06PM +0100, Andreas Färber wrote:
> "... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls?

Changed and added to queque.

Riku

> Am 09.01.2014 10:10, schrieb Will Newton:
> > The regs parameter is not used anywhere, so remove it.
> > 
> > Signed-off-by: Will Newton <will.newton@linaro.org>
> > ---
> >  linux-user/elfload.c   | 3 +--
> >  linux-user/flatload.c  | 3 +--
> >  linux-user/linuxload.c | 4 ++--
> >  linux-user/qemu.h      | 6 ++----
> >  4 files changed, 6 insertions(+), 10 deletions(-)
> 
> Please CC your colleague as the maintainer, scripts/get_maintainer.pl
> --nogit-fallback can help automate that.
> Also you probably wanted patches@linaro.org, too. ;)
> 
> That said, patch contents look fine, without knowing the history,
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Cheers,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg