From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1MI0-00031h-A1 for qemu-devel@nongnu.org; Thu, 09 Jan 2014 15:33:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1MHt-0004dh-R5 for qemu-devel@nongnu.org; Thu, 09 Jan 2014 15:33:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1MHt-0004db-G9 for qemu-devel@nongnu.org; Thu, 09 Jan 2014 15:33:09 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09KX815027385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Jan 2014 15:33:08 -0500 Message-ID: <52CF0781.30409@redhat.com> Date: Thu, 09 Jan 2014 21:33:05 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1389294763-8137-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1389294763-8137-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] acpi: Fix PCI hole handling on SRAT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Gerd Hoffmann On 01/09/14 20:12, Eduardo Habkost wrote: > The original SeaBIOS code used the RamSize variable, that was used by > SeaBIOS for the size of RAM below 4GB, not for all RAM. When copied to > QEMU, the code was changed to use the full RAM size, and this broke the > build_srat() code that handles the PCI hole. > > This series fixes the problem by restoring the original behavior from SeaBIOS. > > Example Linux guest dmesg output when the bug is present (using -m 4G and 4 1GB > NUMA nodes): > SRAT: Node 0 PXM 0 [mem 0x00000000-0x0009ffff] > SRAT: Node 0 PXM 0 [mem 0x00100000-0x3fffffff] > SRAT: Node 1 PXM 1 [mem 0x40000000-0x7fffffff] > SRAT: Node 2 PXM 2 [mem 0x80000000-0xbfffffff] > SRAT: Node 3 PXM 3 [mem 0xc0000000-0xffffffff] > NUMA: nodes only cover 3583MB of your 4095MB e820 RAM. Not used. > Output after the series is applied: > > SRAT: Node 0 PXM 0 [mem 0x00000000-0x0009ffff] > SRAT: Node 0 PXM 0 [mem 0x00100000-0x3fffffff] > SRAT: Node 1 PXM 1 [mem 0x40000000-0x7fffffff] > SRAT: Node 2 PXM 2 [mem 0x80000000-0xbfffffff] > SRAT: Node 3 PXM 3 [mem 0xc0000000-0xdfffffff] > SRAT: Node 3 PXM 3 [mem 0x100000000-0x11fffffff] > > > Eduardo Habkost (2): > pc: Save size of RAM below 4GB > acpi-build: Fix PCI hole handling on build_srat() > > hw/i386/acpi-build.c | 10 +++++----- > hw/i386/pc.c | 1 + > include/hw/i386/pc.h | 2 +- > 3 files changed, 7 insertions(+), 6 deletions(-) > It looks sane to me (which might not mean much of course). series Reviewed-by: Laszlo Ersek