From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1STw-0005ah-Fv for qemu-devel@nongnu.org; Thu, 09 Jan 2014 22:10:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1STo-00071G-OU for qemu-devel@nongnu.org; Thu, 09 Jan 2014 22:10:00 -0500 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:37941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1STo-00070m-2Z for qemu-devel@nongnu.org; Thu, 09 Jan 2014 22:09:52 -0500 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Jan 2014 08:39:47 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 1841B1258055 for ; Fri, 10 Jan 2014 08:41:16 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0A39gd555574638 for ; Fri, 10 Jan 2014 08:39:42 +0530 Received: from d28av05.in.ibm.com (localhost [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0A39iNf015393 for ; Fri, 10 Jan 2014 08:39:44 +0530 Message-ID: <52CF6478.2030207@linux.vnet.ibm.com> Date: Fri, 10 Jan 2014 11:09:44 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1389172118-25402-1-git-send-email-pl@kamp.de> <1389172118-25402-7-git-send-email-pl@kamp.de> <52CE5DF0.2040806@linux.vnet.ibm.com> <52CECD82.4030809@kamp.de> In-Reply-To: <52CECD82.4030809@kamp.de> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: sw@weilnetz.de, aliguori@amazon.com ÓÚ 2014/1/10 0:25, Peter Lieven дµÀ: > Am 09.01.2014 09:29, schrieb Wenchao Xia: >> ÓÚ 2014/1/8 17:08, Peter Lieven дµÀ: >>> Signed-off-by: Peter Lieven >>> --- >>> ui/vnc.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/ui/vnc.c b/ui/vnc.c >>> index da552fe..a742d32 100644 >>> --- a/ui/vnc.c >>> +++ b/ui/vnc.c >>> @@ -3170,7 +3170,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) >>> acl = 1; >>> #endif >>> } else if (strncmp(options, "lossy", 5) == 0) { >>> +#ifdef CONFIG_VNC_JPEG >>> vs->lossy = true; >>> +#endif >>> } else if (strncmp(options, "non-adaptive", 12) == 0) { >>> vs->non_adaptive = true; >>> } else if (strncmp(options, "share=", 6) == 0) { >>> @@ -3187,6 +3189,13 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) >>> } >>> } >>> >>> + /* adaptive updates are only used with tight encoding and >>> + * if lossy updates are enabled so we can disable all the >>> + * calculations otherwise */ >>> + if (!vs->lossy) { >>> + vs->non_adaptive = true; >>> + } >>> + >> The code seems: if vs->loosy == false, then vs->non_adaptive = true, >> translate as: if loosy update is not used, then don't do adaptive >> update., which doesn't conform with the comments. I am not sure if this >> is on expectation. > It don't see the logic break. The option means non_adaptive, not adaptive. > > I write "adaptive updates are only used ... with lossy updates...". Which So tight encoding means loosy updates? > is the same as "without lossy updates we don't need adaptive updates". > > Peter > >> >> >>> #ifdef CONFIG_VNC_TLS >>> if (acl && x509 && vs->tls.x509verify) { >>> if (!(vs->tls.acl = qemu_acl_init("vnc.x509dname"))) { >>> > >