From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1bET-0006Sh-TL for qemu-devel@nongnu.org; Fri, 10 Jan 2014 07:30:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1bEM-0005hm-NU for qemu-devel@nongnu.org; Fri, 10 Jan 2014 07:30:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1bEM-0005hQ-FY for qemu-devel@nongnu.org; Fri, 10 Jan 2014 07:30:30 -0500 Message-ID: <52CFE7C9.9060805@redhat.com> Date: Fri, 10 Jan 2014 13:30:01 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1388062130-21126-1-git-send-email-pl@kamp.de> <20140109141322.GB2862@dhcp-200-207.str.redhat.com> <52CEC998.4040409@kamp.de> <20140110114042.GB4276@dhcp-200-207.str.redhat.com> <52CFE396.7070802@kamp.de> In-Reply-To: <52CFE396.7070802@kamp.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv5] block: add native support for NFS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Kevin Wolf , famz@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, ronniesahlberg@gmail.com Il 10/01/2014 13:12, Peter Lieven ha scritto: > Then I shall convert everything to a qapi schema whereby the current > design of libnfs is designed to work with plain URLs. No, no one is asking you to do this. URLs are fine, but I agree with Kevin that parsing them in QEMU is better. Also because the QEMU parser is known to be based on RFCs and good code from libxml2. For example, the iSCSI URL parser, when introduced, didn't even have percent-escape parsing, causing libvirt to fail with old libiscsi (and actually not that old too: IIRC libiscsi 1.7 will still fail). Unless the libnfs parser is as good as libxml2's, I think there's value in using the QEMU URI parser. Paolo