From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1hOR-0003sZ-QL
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 14:05:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1hOJ-0007RT-06
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 14:05:19 -0500
Received: from mail-qe0-x229.google.com ([2607:f8b0:400d:c02::229]:54212)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1hOI-0007RJ-R8
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 14:05:10 -0500
Received: by mail-qe0-f41.google.com with SMTP id gh4so4982779qeb.28
	for <qemu-devel@nongnu.org>; Fri, 10 Jan 2014 11:05:10 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D04461.9030307@twiddle.net>
Date: Fri, 10 Jan 2014 11:05:05 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389373972-27686-1-git-send-email-peter.maydell@linaro.org>
	<1389373972-27686-4-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389373972-27686-4-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/10] target-arm: A64: Add decode skeleton
 for SIMD data processing insns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/10/2014 09:12 AM, Peter Maydell wrote:
>  static void disas_data_proc_simd(DisasContext *s, uint32_t insn)
>  {
>      /* Note that this is called with all non-FP cases from
>       * table C3-6 so it must UNDEF for entries not specifically
>       * allocated to instructions in that table.
>       */
> -    unsupported_encoding(s, insn);
> +    AArch64DecodeFn *fn = lookup_disas_fn(&data_proc_simd[0], insn);
> +    if (fn) {
> +        (fn) (s, insn);

Oh, do you want to CheckFPAdvSIMDEnabled64 here before calling fn?
Otherwise that's the first thing I noticed missing from patch 4.


r~