From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1hcE-00018v-VN
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 14:19:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1hc6-0003Gd-Kf
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 14:19:34 -0500
Received: from mail-qc0-x233.google.com ([2607:f8b0:400d:c01::233]:60740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1hc6-0003GY-GX
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 14:19:26 -0500
Received: by mail-qc0-f179.google.com with SMTP id e16so2095401qcx.10
	for <qemu-devel@nongnu.org>; Fri, 10 Jan 2014 11:19:26 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D047B9.5040405@twiddle.net>
Date: Fri, 10 Jan 2014 11:19:21 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389373972-27686-1-git-send-email-peter.maydell@linaro.org>
	<1389373972-27686-6-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389373972-27686-6-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/10] target-arm: A64: Add SIMD TBL/TBLX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/10/2014 09:12 AM, Peter Maydell wrote:
> +uint64_t HELPER(simd_tbl)(CPUARMState *env, uint64_t result, uint64_t indices,
> +                          uint64_t rn, uint64_t numregs)

Better with rn and numregs uint32_t?

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~