From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58112)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1iFX-0001Ja-Ce
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 15:00:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1iFR-0003gi-G2
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 15:00:11 -0500
Received: from mail-qa0-x22d.google.com ([2607:f8b0:400d:c00::22d]:62776)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W1iFR-0003fW-CG
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 15:00:05 -0500
Received: by mail-qa0-f45.google.com with SMTP id ii20so790318qab.18
	for <qemu-devel@nongnu.org>; Fri, 10 Jan 2014 12:00:04 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D05140.5000102@twiddle.net>
Date: Fri, 10 Jan 2014 12:00:00 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389373972-27686-1-git-send-email-peter.maydell@linaro.org>
	<1389373972-27686-10-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389373972-27686-10-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/10] target-arm: A64: Add SIMD modified
 immediate group
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/10/2014 09:12 AM, Peter Maydell wrote:
> +    case 0: /* Replicate(Zeros(24):imm8, 2) */
> +    case 1: /* Replicate(Zeros(16):imm8:Zeros(8), 2) */
> +    case 2: /* Replicate(Zeros(8):imm8:Zeros(16), 2) */
> +    case 3: /* Replicate(imm8:Zeros(24), 2) */
> +    {
> +        int shift = cmode_3_1 * 8;
> +        imm = (abcdefgh << shift) | (abcdefgh << (32 + shift));
> +        break;
> +    }

Better to use bitfield_replicate with these?

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~