From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1iiR-0003cR-OI for qemu-devel@nongnu.org; Fri, 10 Jan 2014 15:30:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1iiL-0001vw-Ig for qemu-devel@nongnu.org; Fri, 10 Jan 2014 15:30:03 -0500 Message-ID: <52D057F7.1080709@redhat.com> Date: Fri, 10 Jan 2014 21:28:39 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1385553451-1352-1-git-send-email-kraxel@redhat.com> <5297695B.1010003@redhat.com> In-Reply-To: <5297695B.1010003@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] piix: fix 32bit pci hole List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, "Jordan Justen (Intel address)" , qemu-stable@nongnu.org, Gerd Hoffmann On 11/28/13 17:03, Laszlo Ersek wrote: > Mike, > > On 11/27/13 12:57, Gerd Hoffmann wrote: >> Make the 32bit pci hole start at end of ram, so all possible address >> space is covered. Of course the firmware can use less than that. >> Leaving space unused is no problem, mapping pci bars outside the >> hole causes problems though. >> >> Signed-off-by: Gerd Hoffmann >> --- >> hw/pci-host/piix.c | 10 +--------- >> 1 file changed, 1 insertion(+), 9 deletions(-) >> >> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c >> index edc974e..8e41ac1 100644 >> --- a/hw/pci-host/piix.c >> +++ b/hw/pci-host/piix.c >> @@ -345,15 +345,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, >> f->ram_memory = ram_memory; >> >> i440fx = I440FX_PCI_HOST_BRIDGE(dev); >> - /* Set PCI window size the way seabios has always done it. */ >> - /* Power of 2 so bios can cover it with a single MTRR */ >> - if (ram_size <= 0x80000000) { >> - i440fx->pci_info.w32.begin = 0x80000000; >> - } else if (ram_size <= 0xc0000000) { >> - i440fx->pci_info.w32.begin = 0xc0000000; >> - } else { >> - i440fx->pci_info.w32.begin = 0xe0000000; >> - } >> + i440fx->pci_info.w32.begin = pci_hole_start; >> >> memory_region_init_alias(&f->pci_hole, OBJECT(d), "pci-hole", f->pci_address_space, >> pci_hole_start, pci_hole_size); >> > > please pick this up for 1.7.1. > > 1.7.0 has been released without this patch, also without etc/pci-info, > but with etc/acpi/tables. > > For OVMF to work with "etc/acpi/tables" correctly, with eg. a guest RAM > size of 2560MB, OVMF needs: > - either this patch in qemu, or > - etc/pci-info (which won't come back), or > - a hack in OVMF that mimicks the same 0x80000000/0xc0000000/0xe0000000 > logic (which I won't add). Nominating this for v1.7.1 again. The qemu-2.0 version (ie. a forward-port) of this patch has been merged as ddaaefb piix: fix 32bit pci hole If necessary I can resubmit the v1.7.1 patch. Thanks, Laszlo