From: Richard Henderson <rth@twiddle.net>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [V6 PATCH 16/18] target-ppc: Floating Merge Word Instructions
Date: Fri, 10 Jan 2014 13:34:34 -0800 [thread overview]
Message-ID: <52D0676A.2050706@twiddle.net> (raw)
In-Reply-To: <1389380882-5597-17-git-send-email-tommusta@gmail.com>
On 01/10/2014 11:08 AM, Tom Musta wrote:
> +static void gen_fmrgow(DisasContext *ctx)
> +{
> + TCGv_i64 a1;
> + if (unlikely(!ctx->fpu_enabled)) {
> + gen_exception(ctx, POWERPC_EXCP_FPU);
> + return;
> + }
> + a1 = tcg_temp_new_i64();
> + tcg_gen_shli_i64(a1, cpu_fpr[rA(ctx->opcode)], 32);
> + tcg_gen_deposit_i64(cpu_fpr[rD(ctx->opcode)],
> + a1, cpu_fpr[rB(ctx->opcode)],
> + 0, 32);
> + tcg_temp_free_i64(a1);
> +}
Better use of the deposit when you use it for the shift also:
tcg_gen_deposit_i64(cpu_fpr[rD],
cpu_fpr[rB],
cpu_fpr[rA], 32, 32);
r~
next prev parent reply other threads:[~2014-01-10 21:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 19:07 [Qemu-devel] [V6 PATCH 00/18] target-ppc: VSX Stage 4 Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 01/18] target-ppc: VSX Stage 4: Add VSX 2.07 Flag Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 02/18] target-ppc: VSX Stage 4: Refactor lxsdx Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 03/18] target-ppc: VSX Stage 4: Add lxsiwax, lxsiwzx and lxsspx Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 04/18] target-ppc: VSX Stage 4: Refactor stxsdx Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 05/18] target-ppc: VSX Stage 4: Add stxsiwx and stxsspx Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 06/18] target-ppc: VSX Stage 4: Add xsaddsp and xssubsp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 07/18] target-ppc: VSX Stage 4: Add xsmulsp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 08/18] target-ppc: VSX Stage 4: Add xsdivsp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 09/18] target-ppc: VSX Stage 4: Add xsresp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 10/18] target-ppc: VSX Stage 4: Add xssqrtsp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 11/18] target-ppc: VSX Stage 4: add xsrsqrtesp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 12/18] target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 13/18] target-ppc: VSX Stage 4: Add xscvsxdsp and xscvuxdsp Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 14/18] target-ppc: VSX Stage 4: Add xxleqv, xxlnand and xxlorc Tom Musta
2014-01-10 19:07 ` [Qemu-devel] [V6 PATCH 15/18] target-ppc: Move To/From VSR Instructions Tom Musta
2014-01-10 21:29 ` Richard Henderson
2014-01-14 14:14 ` Tom Musta
2014-01-15 21:07 ` Richard Henderson
2014-01-10 19:08 ` [Qemu-devel] [V6 PATCH 16/18] target-ppc: Floating Merge Word Instructions Tom Musta
2014-01-10 21:34 ` Richard Henderson [this message]
2014-01-10 19:08 ` [Qemu-devel] [V6 PATCH 17/18] target-ppc: Scalar Round to Single Precision Tom Musta
2014-01-10 21:40 ` Richard Henderson
2014-01-10 19:08 ` [Qemu-devel] [V6 PATCH 18/18] target-ppc: Scalar Non-Signalling Conversions Tom Musta
2014-01-10 21:42 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D0676A.2050706@twiddle.net \
--to=rth@twiddle.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).