From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1joj-0001mf-AN for qemu-devel@nongnu.org; Fri, 10 Jan 2014 16:40:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1joa-0004wl-Sm for qemu-devel@nongnu.org; Fri, 10 Jan 2014 16:40:37 -0500 Sender: Richard Henderson Message-ID: <52D068C8.5000701@twiddle.net> Date: Fri, 10 Jan 2014 13:40:24 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389380882-5597-1-git-send-email-tommusta@gmail.com> <1389380882-5597-18-git-send-email-tommusta@gmail.com> In-Reply-To: <1389380882-5597-18-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V6 PATCH 17/18] target-ppc: Scalar Round to Single Precision List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 01/10/2014 11:08 AM, Tom Musta wrote: > This patch adds the VSX Scalar Round to Single Precision (xsrsp) > instruction. > > Signed-off-by: Tom Musta > --- > V6: New. > > target-ppc/fpu_helper.c | 17 +++++++++++++++++ > target-ppc/helper.h | 1 + > target-ppc/translate.c | 2 ++ > 3 files changed, 20 insertions(+), 0 deletions(-) Ok, I guess, although why aren't we passing and returning by value, rather than by reference? This is scalar, so we only need to pass and return uint64_t... r~