From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W20ZD-0003ED-NS
	for qemu-devel@nongnu.org; Sat, 11 Jan 2014 10:33:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W20Z5-0002bT-JB
	for qemu-devel@nongnu.org; Sat, 11 Jan 2014 10:33:43 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52D16447.9020307@redhat.com>
Date: Sat, 11 Jan 2014 16:33:27 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1389386396-22367-1-git-send-email-rth@twiddle.net>
In-Reply-To: <1389386396-22367-1-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-i386: Fix CC_OP_CLR vs PF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: 1267955@bugs.launchpad.net, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Il 10/01/2014 21:39, Richard Henderson ha scritto:
> Parity should be set for a zero result.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-i386/cc_helper.c | 2 +-
>  target-i386/translate.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-i386/cc_helper.c b/target-i386/cc_helper.c
> index ee04092..05dd12b 100644
> --- a/target-i386/cc_helper.c
> +++ b/target-i386/cc_helper.c
> @@ -103,7 +103,7 @@ target_ulong helper_cc_compute_all(target_ulong dst, target_ulong src1,
>      case CC_OP_EFLAGS:
>          return src1;
>      case CC_OP_CLR:
> -        return CC_Z;
> +        return CC_Z | CC_P;
>  
>      case CC_OP_MULB:
>          return compute_all_mulb(dst, src1);
> diff --git a/target-i386/translate.c b/target-i386/translate.c
> index b0f2279..34f35e7 100644
> --- a/target-i386/translate.c
> +++ b/target-i386/translate.c
> @@ -748,7 +748,7 @@ static void gen_compute_eflags(DisasContext *s)
>          return;
>      }
>      if (s->cc_op == CC_OP_CLR) {
> -        tcg_gen_movi_tl(cpu_cc_src, CC_Z);
> +        tcg_gen_movi_tl(cpu_cc_src, CC_Z | CC_P);
>          set_cc_op(s, CC_OP_EFLAGS);
>          return;
>      }
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>