From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1W26zB-0000jA-W1
	for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:25:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1W26z5-0002xj-UJ
	for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:24:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49630)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1W26z5-0002xb-DQ
	for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:24:51 -0500
Message-ID: <52D1C511.6020403@redhat.com>
Date: Sat, 11 Jan 2014 23:26:25 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1386940979-3824-1-git-send-email-kwolf@redhat.com>
	<1386940979-3824-8-git-send-email-kwolf@redhat.com>
In-Reply-To: <1386940979-3824-8-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/24] block: rename buffer_alignment to
 guest_block_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, pl@kamp.de, stefanha@redhat.com

On 13.12.2013 14:22, Kevin Wolf wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> The alignment field is now set to the value that is promised to the
> guest, rather than required by the host.  The next patches will make
> QEMU aware of the host-provided values, so make this clear.
>
> The alignment is also not about memory buffers, but about the sectors on
> the disk, change the documentation of the field.
>
> At this point, the field is set by the device emulation, but completely
> ignored by the block layer.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>   block.c                   | 10 +++++-----
>   hw/block/virtio-blk.c     |  2 +-
>   hw/ide/core.c             |  2 +-
>   hw/scsi/scsi-disk.c       |  2 +-
>   hw/scsi/scsi-generic.c    |  2 +-
>   include/block/block.h     |  2 +-
>   include/block/block_int.h |  4 ++--
>   7 files changed, 12 insertions(+), 12 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>