From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W26ze-0001c7-N4 for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:25:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W26zX-0003Ci-BF for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:25:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W26zX-0003CX-03 for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:25:19 -0500 Message-ID: <52D1C52B.4080801@redhat.com> Date: Sat, 11 Jan 2014 23:26:51 +0100 From: Max Reitz MIME-Version: 1.0 References: <1386940979-3824-1-git-send-email-kwolf@redhat.com> <1386940979-3824-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1386940979-3824-9-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 08/24] raw: Probe required direct I/O alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, pl@kamp.de, stefanha@redhat.com On 13.12.2013 14:22, Kevin Wolf wrote: > From: Paolo Bonzini > > Add a bs->request_alignment field that contains the required > offset/length alignment for I/O requests and fill it in the raw block > drivers. Use ioctls if possible, else see what alignment it takes for > O_DIRECT to succeed. > > While at it, also expose the memory alignment requirements, which may be > (and in practice are) different from the disk alignment requirements. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Kevin Wolf > --- > block.c | 3 ++ > block/raw-posix.c | 102 ++++++++++++++++++++++++++++++++++++++-------- > block/raw-win32.c | 41 +++++++++++++++++++ > include/block/block_int.h | 3 ++ > 4 files changed, 132 insertions(+), 17 deletions(-) Reviewed-by: Max Reitz