From: Max Reitz <mreitz@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, peter.crosthwaite@xilinx.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V9 1/8] snapshot: add parameter *errp in snapshot create
Date: Sat, 11 Jan 2014 23:47:03 +0100 [thread overview]
Message-ID: <52D1C9E7.4070802@redhat.com> (raw)
In-Reply-To: <1388950991-30105-2-git-send-email-xiawenc@linux.vnet.ibm.com>
On 05.01.2014 20:43, Wenchao Xia wrote:
> The return value is only used for error report before this patch,
> so change the function protype to return void.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> block/qcow2-snapshot.c | 30 +++++++++++++++++++++++++-----
> block/qcow2.h | 4 +++-
> block/rbd.c | 19 ++++++++++---------
> block/sheepdog.c | 28 ++++++++++++++++++----------
> block/snapshot.c | 19 +++++++++++++------
> blockdev.c | 10 ++++------
> include/block/block_int.h | 5 +++--
> include/block/snapshot.h | 5 +++--
> qemu-img.c | 10 ++++++----
> savevm.c | 12 ++++++++----
> 10 files changed, 93 insertions(+), 49 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-01-11 22:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 19:43 [Qemu-devel] [PATCH V9 0/8] qcow2: rollback the modification on fail in snapshot creation Wenchao Xia
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 1/8] snapshot: add parameter *errp in snapshot create Wenchao Xia
2014-01-11 22:47 ` Max Reitz [this message]
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 2/8] qcow2: add error message in qcow2_write_snapshots() Wenchao Xia
2014-01-11 22:51 ` Max Reitz
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 3/8] util: add error_append() Wenchao Xia
2014-01-11 22:56 ` Max Reitz
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters() Wenchao Xia
2014-01-11 23:59 ` Max Reitz
2014-01-13 2:11 ` Wenchao Xia
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 5/8] qcow2: full rollback on fail in qcow2_write_snapshots() Wenchao Xia
2014-01-11 23:35 ` Max Reitz
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 6/8] qcow2: rollback on fail in qcow2_snapshot_create() Wenchao Xia
2014-01-11 23:50 ` Max Reitz
2014-01-13 2:30 ` Wenchao Xia
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 7/8] blkdebug: add debug events for snapshot Wenchao Xia
2014-01-05 19:43 ` [Qemu-devel] [PATCH V9 8/8] qemu-iotests: add test for qcow2 snapshot Wenchao Xia
2014-01-11 23:54 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D1C9E7.4070802@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).