From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W27JJ-0003pH-Ly for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:45:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W27JD-0007vr-JS for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:45:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W27JD-0007vn-Az for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:45:39 -0500 Message-ID: <52D1C9E7.4070802@redhat.com> Date: Sat, 11 Jan 2014 23:47:03 +0100 From: Max Reitz MIME-Version: 1.0 References: <1388950991-30105-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388950991-30105-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1388950991-30105-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V9 1/8] snapshot: add parameter *errp in snapshot create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, peter.crosthwaite@xilinx.com, stefanha@redhat.com On 05.01.2014 20:43, Wenchao Xia wrote: > The return value is only used for error report before this patch, > so change the function protype to return void. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 30 +++++++++++++++++++++++++----- > block/qcow2.h | 4 +++- > block/rbd.c | 19 ++++++++++--------- > block/sheepdog.c | 28 ++++++++++++++++++---------- > block/snapshot.c | 19 +++++++++++++------ > blockdev.c | 10 ++++------ > include/block/block_int.h | 5 +++-- > include/block/snapshot.h | 5 +++-- > qemu-img.c | 10 ++++++---- > savevm.c | 12 ++++++++---- > 10 files changed, 93 insertions(+), 49 deletions(-) Reviewed-by: Max Reitz