From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W27No-0005pH-8k for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:50:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W27Ni-0000h8-3r for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:50:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W27Nh-0000h1-S6 for qemu-devel@nongnu.org; Sat, 11 Jan 2014 17:50:18 -0500 Message-ID: <52D1CB00.3030508@redhat.com> Date: Sat, 11 Jan 2014 23:51:44 +0100 From: Max Reitz MIME-Version: 1.0 References: <1388950991-30105-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388950991-30105-3-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1388950991-30105-3-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V9 2/8] qcow2: add error message in qcow2_write_snapshots() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jcody@redhat.com, peter.crosthwaite@xilinx.com, stefanha@redhat.com On 05.01.2014 20:43, Wenchao Xia wrote: > The function still returns int since qcow2_snapshot_delete() will > return the number. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 43 +++++++++++++++++++++++++++++++++++++------ > 1 files changed, 37 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz