Re: [Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters()

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2014/1/12 7:59, Max Reitz 写道:
> On 05.01.2014 20:43, Wenchao Xia wrote:
>> The return value can help caller check whether error happens,
>> and it does not need to have *errp since the return value already tips
>> what happend.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>>   block/qcow2-refcount.c |    8 +++++---
>>   block/qcow2.h          |    6 +++---
>>   2 files changed, 8 insertions(+), 6 deletions(-)
>
> I'm not sure if we actually need this since it's never really bad to
> have an error occur in qcow2_free_clusters(); at least, there's nothing
> the caller can do about that and it never blocks any subsequent
> operation, so most callers just don't care. But it won't hurt, either, so:
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
   In snapshot, L1 table <- snapshot_list, if snapshot_list cluster
is not freed successfully, L1 talble should be kepted to avoid dangling
pointer, So I added this patch to enable the check.