From: Paolo Bonzini <pbonzini@redhat.com>
To: Tom Knych <thomaswk@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
David Turner <digit@google.com>,
qemu-devel@nongnu.org, gleb@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/1] KVM: Retry KVM_CREATE_VM on EINTR or EAGAIN
Date: Mon, 13 Jan 2014 12:16:11 +0100 [thread overview]
Message-ID: <52D3CAFB.8030003@redhat.com> (raw)
In-Reply-To: <CAB=aRPM7J0fWCb_ZUkc+8BVBKEaZm+oH7D0SYNJ=K8myBmk0pg@mail.gmail.com>
Il 10/01/2014 23:15, Tom Knych ha scritto:
> I'll flip the conditional check
>
> So I traced thru the code and the one path I saw returning EINTR was:
>
> kvm_dev_ioctl_create_vm -> kvm_create_vm -> kvm_init_mmu_notifier ->
> mmu_notifier_register -> do_mmu_notifier_register -> mm_take_all_locks
>
> Which checks if any signals have been raised while it was attaining
> locks and returns EINTR.
>
> Going thru my logs - all of my errors actually are EINTRs I'll remove
> the EAGAIN
Andrea, what do you think here? Is it intended that
kvm_init_mmu_notifier return an EINTR that percolates up to userspace?
Paolo
next prev parent reply other threads:[~2014-01-13 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:14 [Qemu-devel] [PATCH 0/1] KVM: Retry KVM_CREATE_VM on EINTR or EAGAIN thomas knych
2014-01-09 21:14 ` [Qemu-devel] [PATCH 1/1] " thomas knych
2014-01-10 13:01 ` Paolo Bonzini
2014-01-10 22:15 ` Tom Knych
2014-01-13 11:16 ` Paolo Bonzini [this message]
2014-01-14 18:56 ` Andrea Arcangeli
2014-01-15 2:09 ` Tom Knych
2014-01-15 7:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D3CAFB.8030003@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=digit@google.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thomaswk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).