From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W2g5i-00065R-H5
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 06:54:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W2g5c-0007Aj-Hs
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 06:54:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45234)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1W2g5c-0007Ac-AS
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 06:53:56 -0500
Message-ID: <52D3D3BC.1050009@redhat.com>
Date: Mon, 13 Jan 2014 12:53:32 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1389304508-10100-1-git-send-email-steven@uplinklabs.net>	<52CF2561.7050105@redhat.com>
	<52CF2E2F.4060005@comstyle.com> <20140111023621.GA27157@amazon.com>
	<52D0F6E6.9090502@weilnetz.de>
In-Reply-To: <52D0F6E6.9090502@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable
 -fstack-protector flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Steven Noonan <steven@uplinklabs.net>, "Noonan,
	Steven" <snoonan@amazon.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Brad Smith <brad@comstyle.com>

Il 11/01/2014 08:46, Stefan Weil ha scritto:
> Hi Steven,
> 
> --disable-stack-protector would also be useful for platforms which make
> debugging of executables with stack protection difficult. When I must
> debug Windows executables, I always disable stack protection, because
> otherwise the stack back traces are unreadable.
> 
> So, for MinGW it might be reasonable to set the default to no stack
> protection if --enable-debug is selected. This requires some
> modifications in your patch.
> 
> # Don't set it to "yes" initially:
> stack_protector=""
> 
> # Do the compile test if it is not "no":
> if test "$stack_protector" != "no"; then

Apart from this little detail, the patch looks good.

Steven, please resend the patch as a top-level message with the patch
inline rather than attached.  This is needed so that Anthony's script
will pick it up.  Including these changes would be nice too.

Paolo

> The usual logic is do nothing if the user says "no". Run the compile
> tests otherwise. Show an error message if the compile tests fail and the
> user said "yes". See the code which handles $pie for an example.
> 
> Please send your next patch inline - this makes it easier to add comments.
> 
> Best regards
> 
> Stefan
>