From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W2iwr-0004dO-84
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 09:57:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W2iwi-0003bp-Nc
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 09:57:05 -0500
Received: from mail-qa0-x22a.google.com ([2607:f8b0:400d:c00::22a]:55494)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1W2iwi-0003bh-IW
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 09:56:56 -0500
Received: by mail-qa0-f42.google.com with SMTP id k4so3972620qaq.15
	for <qemu-devel@nongnu.org>; Mon, 13 Jan 2014 06:56:55 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52D3FEB1.9040703@redhat.com>
Date: Mon, 13 Jan 2014 15:56:49 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1388934290-27700-1-git-send-email-mmishael@redhat.com>
	<52CC1310.7070406@redhat.com>
	<DECD048F-03FE-42EB-9358-75B1D1849669@redhat.com>
	<52CD78C4.8070403@redhat.com>
	<1389607987.9142.48.camel@nilsson.home.kraxel.org>
	<20140113144803.GA30636@redhat.com>
In-Reply-To: <20140113144803.GA30636@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support
	in qemupciserial.inf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Yan Vugenfirer <yvugenfi@redhat.com>, qemu-devel list <qemu-devel@nongnu.org>, Ronen Hod <rhod@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Dmitry Fleytman <dfleytma@redhat.com>, Miki Mishael <mmishael@redhat.com>

Il 13/01/2014 15:48, Michael S. Tsirkin ha scritto:
> 
>         if (pci_dev->revision != VIRTIO_PCI_ABI_VERSION) {
>                 printk(KERN_ERR "virtio_pci: expected ABI version %d,
> got %d\n",
>                        VIRTIO_PCI_ABI_VERSION, pci_dev->revision);
>                 return -ENODEV;
>         }
> 
> so it seems better to be consistent.
> in any case, we must check subsystem ids, the spec is very
> explicit on this point.

This is not a virtio device.

Paolo