From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48643)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W2k4f-0005iL-Ql
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 11:09:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W2k4a-0000sH-9Y
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 11:09:13 -0500
Received: from mail-qc0-x235.google.com ([2607:f8b0:400d:c01::235]:63945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W2k4a-0000sD-4u
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 11:09:08 -0500
Received: by mail-qc0-f181.google.com with SMTP id e9so6337116qcy.26
	for <qemu-devel@nongnu.org>; Mon, 13 Jan 2014 08:09:07 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D40F9E.60205@twiddle.net>
Date: Mon, 13 Jan 2014 08:09:02 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389622396-32282-1-git-send-email-peter.maydell@linaro.org>
	<1389622396-32282-4-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389622396-32282-4-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 03/10] target-arm: A64: Add decode
 skeleton for SIMD data processing insns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/13/2014 06:13 AM, Peter Maydell wrote:
> From: Alex Bennée <alex.bennee@linaro.org>
> 
> Add decode skeleton and function placeholders for all the SIMD data
> processing instructions. Due to the complexity of this part of the
> table the normal extract and switch approach gets very messy very
> quickly, so we use a simple data-driven pattern-and-mask approach.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> ---
> v1->v2:
>  * made data_proc_simd table const
>  * fixed errors in insn diagram comments
>  * fixed coding style for fn pointer call
> ---
>  target-arm/translate-a64.c | 306 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 305 insertions(+), 1 deletion(-)


Reviewed-by: Richard Henderson <rth@twiddle.net>


r~