From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Michael Matz" <matz@suse.de>,
"Alexander Graf" <agraf@suse.de>,
"Claudio Fontana" <claudio.fontana@linaro.org>,
"Dirk Mueller" <dmueller@suse.de>,
"Will Newton" <will.newton@linaro.org>,
"Laurent Desnogues" <laurent.desnogues@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvmarm@lists.cs.columbia.edu,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 04/10] target-arm: A64: Add SIMD EXT
Date: Mon, 13 Jan 2014 08:16:56 -0800 [thread overview]
Message-ID: <52D41178.9040305@twiddle.net> (raw)
In-Reply-To: <1389622396-32282-5-git-send-email-peter.maydell@linaro.org>
On 01/13/2014 06:13 AM, Peter Maydell wrote:
> + if (!is_q) {
> + read_vec_element(s, tcg_resl, rn, 0, MO_64);
> + if (pos != 0) {
> + read_vec_element(s, tcg_resh, rm, 0, MO_64);
> + read_vec_element(s, tcg_resl, rn, 0, MO_64);
Duplicate resl read.
Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-01-13 16:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 14:13 [Qemu-devel] [PATCH v2 00/10] A64 SIMD patchset one: ld/st, C3.6.1..C3.6.7 Peter Maydell
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 01/10] target-arm: A64: Add SIMD ld/st multiple Peter Maydell
2014-01-13 16:07 ` Richard Henderson
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 02/10] target-arm: A64: Add SIMD ld/st single Peter Maydell
2014-01-13 16:08 ` Richard Henderson
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 03/10] target-arm: A64: Add decode skeleton for SIMD data processing insns Peter Maydell
2014-01-13 16:09 ` Richard Henderson
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 04/10] target-arm: A64: Add SIMD EXT Peter Maydell
2014-01-13 16:16 ` Richard Henderson [this message]
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 05/10] target-arm: A64: Add SIMD TBL/TBLX Peter Maydell
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 06/10] target-arm: A64: Add SIMD ZIP/UZP/TRN Peter Maydell
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 07/10] target-arm: A64: Add SIMD across-lanes instructions Peter Maydell
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 08/10] target-arm: A64: Add SIMD copy operations Peter Maydell
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 09/10] target-arm: A64: Add SIMD modified immediate group Peter Maydell
2014-01-13 14:13 ` [Qemu-devel] [PATCH v2 10/10] target-arm: A64: Add SIMD scalar copy instructions Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D41178.9040305@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=claudio.fontana@linaro.org \
--cc=dmueller@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=laurent.desnogues@gmail.com \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).