From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W2kCJ-0000UX-Nx
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 11:17:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W2kCD-0003SG-NJ
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 11:17:07 -0500
Received: from mail-qa0-x234.google.com ([2607:f8b0:400d:c00::234]:58543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1W2kCD-0003S8-IL
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 11:17:01 -0500
Received: by mail-qa0-f52.google.com with SMTP id j15so6068026qaq.39
	for <qemu-devel@nongnu.org>; Mon, 13 Jan 2014 08:17:01 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52D41178.9040305@twiddle.net>
Date: Mon, 13 Jan 2014 08:16:56 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1389622396-32282-1-git-send-email-peter.maydell@linaro.org>
	<1389622396-32282-5-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1389622396-32282-5-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/10] target-arm: A64: Add SIMD EXT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 01/13/2014 06:13 AM, Peter Maydell wrote:
> +    if (!is_q) {
> +        read_vec_element(s, tcg_resl, rn, 0, MO_64);
> +        if (pos != 0) {
> +            read_vec_element(s, tcg_resh, rm, 0, MO_64);
> +            read_vec_element(s, tcg_resl, rn, 0, MO_64);

Duplicate resl read.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~