From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru,
alex@alex.org.uk, mrezanin@redhat.com, vilanova@ac.upc.edu
Subject: Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading
Date: Mon, 13 Jan 2014 14:15:42 -0800 [thread overview]
Message-ID: <52D4658E.10203@twiddle.net> (raw)
In-Reply-To: <1389632394-10130-7-git-send-email-pbonzini@redhat.com>
On 01/13/2014 08:59 AM, Paolo Bonzini wrote:
> +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak
I really really don't like random numbers that make for non-repeatable builds.
It's a quality-assurance nightmare.
If you want a non-random number unique to the build, try
git log -n1 --format=format:%H
and perhaps a file containing that hash created by scripts/make-release.
r~
next prev parent reply other threads:[~2014-01-13 22:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 16:59 [Qemu-devel] [PATCH v15 0/9] Shared library module support Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 1/9] rules.mak: fix $(obj) to a real relative path Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 2/9] rules.mak: allow per object cflags and libs Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 3/9] block: use per-object " Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic Paolo Bonzini
2014-01-13 22:11 ` Peter Maydell
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 5/9] build-sys: introduce common-obj-m and block-obj-m for DSO Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 6/9] module: implement module loading Paolo Bonzini
2014-01-13 22:05 ` Peter Maydell
2014-01-14 3:21 ` Fam Zheng
2014-01-13 22:09 ` Peter Maydell
2014-01-14 3:18 ` Fam Zheng
2014-01-13 22:15 ` Richard Henderson [this message]
2014-01-14 3:06 ` Fam Zheng
2014-01-14 14:47 ` Richard Henderson
2014-01-14 15:19 ` Paolo Bonzini
2014-01-14 15:25 ` Peter Maydell
2014-01-14 15:31 ` Paolo Bonzini
2014-01-14 15:43 ` Richard Henderson
2014-01-14 15:47 ` Daniel P. Berrange
2014-01-14 15:45 ` Daniel P. Berrange
2014-01-15 8:28 ` Fam Zheng
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 7/9] Makefile: install modules with "make install" Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 8/9] .gitignore: ignore module related files (dll, so, mo) Paolo Bonzini
2014-01-13 16:59 ` [Qemu-devel] [PATCH v15 9/9] block: convert block drivers linked with libs to modules Paolo Bonzini
2014-01-13 22:01 ` [Qemu-devel] [PATCH v15 0/9] Shared library module support Peter Maydell
2014-01-14 7:47 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D4658E.10203@twiddle.net \
--to=rth@twiddle.net \
--cc=alex@alex.org.uk \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mrezanin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).