From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2pnb-00064e-2Y for qemu-devel@nongnu.org; Mon, 13 Jan 2014 17:16:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2pnQ-0002XA-Bk for qemu-devel@nongnu.org; Mon, 13 Jan 2014 17:15:59 -0500 Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:41012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2pnQ-0002X5-4H for qemu-devel@nongnu.org; Mon, 13 Jan 2014 17:15:48 -0500 Received: by mail-qc0-f175.google.com with SMTP id x13so5902720qcv.20 for ; Mon, 13 Jan 2014 14:15:47 -0800 (PST) Sender: Richard Henderson Message-ID: <52D4658E.10203@twiddle.net> Date: Mon, 13 Jan 2014 14:15:42 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1389632394-10130-1-git-send-email-pbonzini@redhat.com> <1389632394-10130-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1389632394-10130-7-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru, alex@alex.org.uk, mrezanin@redhat.com, vilanova@ac.upc.edu On 01/13/2014 08:59 AM, Paolo Bonzini wrote: > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak I really really don't like random numbers that make for non-repeatable builds. It's a quality-assurance nightmare. If you want a non-random number unique to the build, try git log -n1 --format=format:%H and perhaps a file containing that hash created by scripts/make-release. r~