From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2qFo-0000vh-Jv for qemu-devel@nongnu.org; Mon, 13 Jan 2014 17:45:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2qFk-0002mz-6I for qemu-devel@nongnu.org; Mon, 13 Jan 2014 17:45:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2qFj-0002ll-V6 for qemu-devel@nongnu.org; Mon, 13 Jan 2014 17:45:04 -0500 Message-ID: <52D46C6D.8070300@redhat.com> Date: Mon, 13 Jan 2014 15:45:01 -0700 From: Eric Blake MIME-Version: 1.0 References: <1389652389-22241-1-git-send-email-romain.naour@openwide.fr> <1389652389-22241-2-git-send-email-romain.naour@openwide.fr> In-Reply-To: <1389652389-22241-2-git-send-email-romain.naour@openwide.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="347DqbWBsievB4vq0oJ8IunEFtsud5wvR" Subject: Re: [Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Romain Naour , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --347DqbWBsievB4vq0oJ8IunEFtsud5wvR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/13/2014 03:33 PM, Romain Naour wrote: > This patch adds the emulation for a serial Genius mouse using > Mouse Systems protocol (5bytes). > This protocol is compatible with most 3-button serial mouse. >=20 > Signed-off-by: Romain Naour > --- > backends/Makefile.objs | 2 +- > backends/gnmouse.c | 339 +++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/sysemu/char.h | 3 + > qapi-schema.json | 1 + > qemu-char.c | 4 + > qemu-options.hx | 10 ++ > 6 files changed, 358 insertions(+), 1 deletion(-) > create mode 100644 backends/gnmouse.c > +++ b/backends/gnmouse.c > @@ -0,0 +1,339 @@ > +/* > + * QEMU Genius GM-6 serial mouse emulation > + * > + * Adapted from msmouse > + * > + * Copyright (c) 2012 Romain Naour It is now 2014. > +++ b/qapi-schema.json > @@ -3617,6 +3617,7 @@ > 'null' : 'ChardevDummy', > 'mux' : 'ChardevMux', > 'msmouse': 'ChardevDummy', > + 'gnmouse': 'ChardevDummy', > 'braille': 'ChardevDummy', > 'stdio' : 'ChardevStdio', > 'console': 'ChardevDummy', Ideally, you should also document that this branch was not always available in the union (I was expecting to see a doc line with '(since 2.0)' somewhere in the patch); but looking at the existing schema, you're just copying bad practice of adding to an already under-documented union. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --347DqbWBsievB4vq0oJ8IunEFtsud5wvR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJS1GxtAAoJEKeha0olJ0NqLLEH+wUZDOSWfmsYEwBYT7XxhG2q g2KUBsuMaMsAxazF1L/jY+MAHnfxr7YcKZeCcY/ifJQ9gDu3DzCn8nHEfhmBR1L5 kIWjoGR0JT7bK7ZlExdwBK40oLyr0VVpY3/GfwqbE7dSsQ8h3p7tKEfXm8yhK+WW AnSeYIOaXo43/+R2rmkANJP40bIEZjpemmjILPLqth/WU2O7JHHgObjE63kxQyhE JYC3IAIffbwE49KCxvzDc8gmXCT7VNoTmT3oBmxYdxoln49SD9k5E6twqvldv8PJ T5eKX8GEDyyZo9IYfLqWyQPsg0dRmWwIxvD1KVMjj9dRn931tleIylMoaOI2z0w= =k6fo -----END PGP SIGNATURE----- --347DqbWBsievB4vq0oJ8IunEFtsud5wvR--