From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1W2zQE-0007r4-TH
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 03:32:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1W2zQA-0007ZA-8B
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 03:32:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16716)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1W2zQA-0007Xq-04
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 03:32:26 -0500
Message-ID: <52D4F677.7060709@redhat.com>
Date: Tue, 14 Jan 2014 10:33:59 +0200
From: Gal Hammer <ghammer@redhat.com>
MIME-Version: 1.0
References: <20140113172514.11163.75410.stgit@helix>
	<20140113172529.11163.32538.stgit@helix>
In-Reply-To: <20140113172529.11163.32538.stgit@helix>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] qga: vss-win32: Fix interference with
 snapshot creation by other VSS requesters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, mitsuhiro.tanino@hds.com, rhod@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, areis@redhat.com

On 13/01/2014 19:25, Tomoki Sekiyama wrote:
> When a VSS requester such as vshadow.exe or diskshadow.exe requests to
> create disk snapshots, Windows may choose qemu-ga VSS provider if it is
> only provider registered on the system. However, because it provides only a
> function to freeze the filesystem, the snapshotting fails.
>
> This patch adds a check into CQGAVssProvider::IsVolumeSupported() to reject
> the request from other VSS requesters, so that the other provider is chosen.
>
> The check of requester is done by confirming event channels between
> qemu-ga's requester and provider established. To ensure that the events are
> initialized when CQGAVssProvider::IsVolumeSupported() is called, it moves
> the initialization earlier.
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>

Reviewed-by: Gal Hammer <ghammer@redhat.com>

     Gal.