From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zQi-0008NJ-ND for qemu-devel@nongnu.org; Tue, 14 Jan 2014 03:33:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2zQd-0007jG-4N for qemu-devel@nongnu.org; Tue, 14 Jan 2014 03:33:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zQc-0007j9-SX for qemu-devel@nongnu.org; Tue, 14 Jan 2014 03:32:55 -0500 Message-ID: <52D4F692.2030404@redhat.com> Date: Tue, 14 Jan 2014 10:34:26 +0200 From: Gal Hammer MIME-Version: 1.0 References: <20140113172514.11163.75410.stgit@helix> <20140113172539.11163.2952.stgit@helix> In-Reply-To: <20140113172539.11163.2952.stgit@helix> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] qga: vss-win32: Fix interference with snapshot deletion by other VSS request List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, mitsuhiro.tanino@hds.com, rhod@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, areis@redhat.com On 13/01/2014 19:25, Tomoki Sekiyama wrote: > When a VSS requester such as vshadow.exe or diskshadow.exe requests to > delete snapshots, qemu-ga VSS provider's DeleteSnapshots() is also called > and returns E_NOTIMPL, that makes the deletion fail. > To avoid this issue, return S_OK and set values that represent no snapshots > are deleted by qemu-ga VSS provider. > > Signed-off-by: Tomoki Sekiyama Reviewed-by: Gal Hammer Gal.